Rename nWayUnion => multiwayMerge and NWayUnion => MultiwayMerge#5619
Rename nWayUnion => multiwayMerge and NWayUnion => MultiwayMerge#5619andralex merged 1 commit intodlang:masterfrom
Conversation
RazvanN7
requested review from
JackStouffer,
andralex and
wilzbach
as code owners
|
Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
| assert(equal(multiwayMerge(a), witness)); | ||
| } | ||
|
|
||
| alias nWayUnion = multiwayMerge; |
There was a problem hiding this comment.
cool, also please add alias NWayUnion = NWayMerge and mention it in the doc. Forgot to mention that.
RazvanN7
force-pushed
the
Issue_6718_partial_fix
branch
from
fda0f64 to
e471b22
Compare
| } | ||
|
|
||
| alias nWayUnion = multiwayMerge; | ||
| alias NWayUnion = MultiwayMerge; |
|
Q: Why do we need the
|
|
@wilzbach algorithms for multiple set intersection are very different from those that intersect a small fixed number of sets, and have their own theory, practice, and important applications. I figure it's good to expose them under a different name rather than under the one-argument version of |
|
I'll force merge this, looks like the SHA matter is spurious. cc @CyberShadow |
|
Yes, as far as I can tell, the SHA mismatch errors are due to a bug in GitHub: Force-merging will probably not break master, so it should be fine if there are no obvious DDoc errors. |
Actually, I take that back. The SHA mismatch error indicates that there is a mismatch between the commits on the website and the commits in git. This potentially means that the tested change and the merged change are not the same! I don't know how the other CIs fetch the commits to test, but if potentially they use the same method as DAutoTest but do not verify that the fetched PR's head commit SHA1 coincides with the SHA1 from the API, then they might be testing the wrong changes. So, I suggest being cautious about merging PRs with SHA1 mismatch errors for now. |
5 participants
And adds: alias nWayUnion = multiwayMerge. Also the documentation is updated accordingly.
This is a partial fix to Issue 6718[1]
[1] https://issues.dlang.org/show_bug.cgi?id=6718